module NewPage doesn't honour template selection

Summary:

When user creates new page via the NewPage module, and selects a template from the list provided, the selection is ignored and the last option in the list of templates is chosen instead.

module NewPage doesn't honour template selection

andrewescott 07 Oct 2007 10:02

In the nav:side panel of my wiki at 99sauces.wikidot.com, I have some code to allow users to quickly create a new page:

[[module NewPage size="15" template="template:person,template:place,template:producer" button="new page"]]

There are three templates listed, as users are meant to create only those pages relating to those templates. However, no matter which template the user selects, the Producer template is always used by the NewPage module.

Re: module NewPage doesn't honour template selection

hartnell 07 Oct 2007 10:41

Let me check the docs. :) —hartnell

---

"Early in life I learned that I was a firestarter. When I learned that I could light fires of passion I became a pyromaniac. My greatest desire is to set the world on fire." — Shawn Hartnell

Re: module NewPage doesn't honour template selection

hartnell 07 Oct 2007 10:48

It's seems you did everything correctly. What happens when you include two or rather than three templates? —hartnell

---

"Early in life I learned that I was a firestarter. When I learned that I could light fires of passion I became a pyromaniac. My greatest desire is to set the world on fire." — Shawn Hartnell

Re: module NewPage doesn't honour template selection

andrewescott 12 Mar 2008 11:04

Bit slow about responding, as I sort of hoped someone would fix this in the meantime, but that hasn't happened.

The problem still happens with two templates, but it doesn't happen with one template, i.e. this works fine:

[[module NewPage template="template:blah"]]

but this does not:

[[module NewPage template="template:blah, template:blah2"]]

In fact, after a bit of experimenting, it seems that if you provide multiple templates in the list, the last template is always the one used, no matter which one is chosen. (It doesn't matter whether there is a space after the comma or not.)

I've confirmed this using both Firefox 2 and IE 7.

If anyone else wants to test this, and assuming it's still there, I've got a scratch page up on the sandbox for this at http://sandbox.wikidot.com/show-templates

Re: module NewPage doesn't honour template selection

andrewescott 19 Mar 2008 11:04

I've looked at the HTML generated by Wikidot for the http://sandbox.wikidot.com/show-templates page, and the problem becomes clearer..

<form action="dummy.html" method="get" onsubmit="WIKIDOT.modules.NewPageHelperModule.listeners.create(event)">
  <input class="text" name="pageName" type="text" size="30" maxlength="60" style="margin: 1px"/>
  <select name="template" style="margin: 1px">
    <option value="" selected="selected">-- Select a template --</option>
    <option value="254926">Cat1</option>
    <option value="294735">Breads</option>
    <option value="294768">Wines</option>
    <option value="5848">Rateit</option>
  </select>
  <input type="submit" class="button" value="create page" style="margin: 1px"/>
  <input type="hidden" name="template" value="5848"/>
</form>

Note that there are two form fields with the name "template": there's the select list and the hidden field. The hidden field is specifying the templateId for the last template in the list (Rateit), and over-rides any choice made by the user in the select list. The hidden field is normally used when there is a single template, pre-specified in the NewPage module, but should not be included when there are multiple templates.

Re: module NewPage doesn't honour template selection

andrewescott 20 Mar 2008 11:29

Ok. I think I've found the bug. Looking in the Wikidot v1 source, the template file at /templates/modules/misc/NewPageHelperModule.tpl has the following code fragment:

{foreach from=$templates item=template}
      <option value="{$template->getPageId()}">{$template->getTitleOrUnixName()|escape}</option>
    {/foreach}
  </select>
{/if}
<input type="submit" class="button" value="{if $button}{$button|escape}{else}{t}create page{/t}{/if}" style="margin: 1px"/>
{if $categoryName}
  <input type="hidden" name="categoryName" value="{$categoryName}"/>
{/if}
{if $template}
  <input type="hidden" name="template" value="{$template->getPageId()}"/>

In the foreach loop, the variable $template is set to each of the entries of the $templates variable. Then, at the end of the code fragment, $template is still set to the last entry, so the hidden field is written out.

A solution would be to use a different variable name in the foreach loop instead of template, e.g. templateoption.

Re: module NewPage doesn't honour template selection

Gabrys 30 Apr 2008 19:32

Thank you for this, we will adapt this patch (if you don't mind) soon.

Sorry for long inactivity from us, we're working on it now.

---

Piotr Gabryjeluk
visit my blog

Last edited on 30 Apr 2008 19:34 by Gabrys + Show more

Re: module NewPage doesn't honour template selection

andrewescott 17 Jun 2008 12:31

Hi Gabrys.

I note that this is still not fixed (using the test page at http://sandbox.wikidot.com/show-templates). Surely it can't take this long to make the changes. If it were complex, I could understand, but this should take, literally, 30 seconds to modify the two lines of code in the three places required, and it would be done.